This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Multi-precision AdamW update op #14171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel
This reverts commit 5869e0a.
|
@ptrendx you might be interested |
|
@eric-haibin-lin Thanks for the contribution! @apeforest Could you please help review this PR |
eric-haibin-lin
changed the title
|
i'll add more tests. |
eric-haibin-lin
changed the title
szha
approved these changes
Feb 18, 2019
|
@larroy @marcoabreu any idea why the test status is always pending? |
|
@eric-haibin-lin what I hear is that when jenkins tries to update the status back to github, the DNS resolution may fail which causes the message to be dropped. I retriggered the test to hopefully fix the status. |
Merged
7 tasks
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* mp adamw update * Softmax fp16 (apache#201) * softmax for fp16 with fp32 accumulator * return AType in kernel * add dtype * kernel * adamw with nan check * add doc * Revert "Softmax fp16 (apache#201)" This reverts commit 5869e0a. * add test * more test for fp16 * skip update for rescale = 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested in gluon-nlp.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments